Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX / bnb: fix torch compatiblity issue with itemize #30162

Merged
merged 3 commits into from
Apr 10, 2024
Merged

FIX / bnb: fix torch compatiblity issue with itemize #30162

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5efc925
fix torch compatiblity issues
younesbelkada Apr 10, 2024
64c66c9
fix
younesbelkada Apr 10, 2024
8e5c9d8
Update src/transformers/modeling_utils.py
younesbelkada Apr 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/transformers/modeling_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1159,9 +1159,12 @@ def num_parameters(self, only_trainable: bool = False, exclude_embeddings: bool
# For 4bit models, we need to multiply the number of parameters by 2 as half of the parameters are
# used for the 4bit quantization (uint8 tensors are stored)
if is_loaded_in_4bit and isinstance(param, bnb.nn.Params4bit):
total_numel.append(
param.numel() * 2 * self.hf_quantizer.quantization_config.bnb_4bit_quant_storage.itemsize
quant_storage = self.hf_quantizer.quantization_config.bnb_4bit_quant_storage
# For compatibility with older PT version - see: https://github.com/huggingface/peft/pull/1635
nb_params = (
quant_storage.itemsize if hasattr(quant_storage, "itemsize") else quant_storage.element_size()
)
total_numel.append(param.numel() * 2 * nb_params)
else:
total_numel.append(param.numel())

Expand Down