Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for parse_json_file and change typing to os.PathLike #30183

Merged
merged 6 commits into from Apr 15, 2024
Merged

Add test for parse_json_file and change typing to os.PathLike #30183

merged 6 commits into from Apr 15, 2024

Conversation

xu-song
Copy link
Contributor

@xu-song xu-song commented Apr 11, 2024

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

amyeroberts
amyeroberts reviewed Apr 11, 2024
View reviewed changes
Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the types!

The test shouldn't be modified

tests/utils/test_hf_argparser.py Show resolved Hide resolved
amyeroberts
amyeroberts approved these changes Apr 12, 2024
View reviewed changes
Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating!

@amyeroberts amyeroberts merged commit 8fd2de9 into huggingface:main Apr 15, 2024
20 checks passed
zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request Apr 18, 2024
@xu-song @zucchini-nlp
Add test for parse_json_file and change typing to os.PathLike (huggin…
b9009d0 
…gface#30183)

* Add test for parse_json_file

* Change Path to PathLike

* Fix `Import block is un-sorted or un-formatted`

* revert parse_json_file

* Fix ruff format

* Add parse_json_file test
ArthurZucker pushed a commit that referenced this pull request Apr 22, 2024
@xu-song @ArthurZucker
Add test for parse_json_file and change typing to os.PathLike (#30183)
217d428 
* Add test for parse_json_file

* Change Path to PathLike

* Fix `Import block is un-sorted or un-formatted`

* revert parse_json_file

* Fix ruff format

* Add parse_json_file test
itazap pushed a commit that referenced this pull request May 14, 2024
@xu-song
Add test for parse_json_file and change typing to os.PathLike (#30183)
d292063 
* Add test for parse_json_file

* Change Path to PathLike

* Fix `Import block is un-sorted or un-formatted`

* revert parse_json_file

* Fix ruff format

* Add parse_json_file test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyeroberts amyeroberts amyeroberts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xu-song @amyeroberts