Support multiple validation datasets when dataloader_persistent_workers=True
#30627
+30
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #30527
This PR adds support for multiple validation datasets in
transformers.Trainer
whendataloader_persistent_workers=True
. The current behavior is that all validations will be done on the first validation dataset.I had to pass the
validation_dataset_name
to theevaluate
andget_eval_dataloader
methods so that the right validation dataloader could be retrieved.Who can review?
@muellerzr