Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple validation datasets when dataloader_persistent_workers=True #30627

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bastienlc
Copy link

What does this PR do?

Fixes #30527

This PR adds support for multiple validation datasets in transformers.Trainer when dataloader_persistent_workers=True. The current behavior is that all validations will be done on the first validation dataset.

I had to pass the validation_dataset_name to the evaluate and get_eval_dataloader methods so that the right validation dataloader could be retrieved.

Who can review?

@muellerzr

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link

github-actions bot commented Jun 2, 2024

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple validation datasets unsupported with dataloader_persistent_workers=True
2 participants