fixes clip interpolate #30783
Open
fixes clip interpolate #30783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
nileshkokane01
force-pushed
the
interpolate_clip
branch
from
dd72bd1
to
6ed7b47
Compare
amyeroberts
reviewed
May 15, 2024
There was a problem hiding this comment.
Thanks for working on this!
A few general comments:
interpolate_pos_encodingshould be a boolean- It should be possible to call the model with this flag i.e.
model(**inputs, interpolate_pos_encoding) - All the docstrings should be updated to include this argument
- Print statements should be removed
- Tests should make sure that the process image being passed to the model is not the default size
| @@ -1099,6 +1136,7 @@ def forward( | |||
| output_attentions: Optional[bool] = None, | |||
| output_hidden_states: Optional[bool] = None, | |||
| return_dict: Optional[bool] = None, | |||
| interpolate_pos_encoding: Optional[bool] = False, | |||
There was a problem hiding this comment.
The value should be True or False, but not None
Suggested change
| interpolate_pos_encoding: Optional[bool] = False, | |
| interpolate_pos_encoding: bool = False, |
| image_processor = BridgeTowerProcessor.from_pretrained(model_name) | ||
|
|
||
| image = Image.open("./tests/fixtures/tests_samples/COCO/000000039769.png") | ||
| inputs = image_processor(text="what's in the image", images=image, return_tensors="pt").to(torch_device) |
| image_processor = ChineseCLIPProcessor.from_pretrained(model_name) | ||
|
|
||
| image = Image.open("./tests/fixtures/tests_samples/COCO/000000039769.png") | ||
| inputs = image_processor(text="what's in the image", images=image, return_tensors="pt").to(torch_device) |
| # to visualize self-attention on higher resolution images. | ||
| model = CLIPModel.from_pretrained("openai/clip-vit-base-patch32").to(torch_device) | ||
|
|
||
| image_processor = CLIPProcessor.from_pretrained("openai/clip-vit-base-patch32", size=480) |
There was a problem hiding this comment.
Three comments:
- This is returning the processor, not the image_processor
sizeshould be a dictionary e.g.size={"shortest_edge": 480}here- This won't test the interpolation, because the image processor crops after resizing.
crop_sizealso has to be overriden
Suggested change
| image_processor = CLIPProcessor.from_pretrained("openai/clip-vit-base-patch32", size=480) | |
| processor = CLIPProcessor.from_pretrained("openai/clip-vit-base-patch32", size=480) |
| processor = AutoProcessor.from_pretrained("microsoft/kosmos-2-patch14-224", padding_side="left") | ||
|
|
||
| image = Image.open("./tests/fixtures/tests_samples/COCO/000000039769.png") | ||
| inputs = processor(text="what's in the image", images=image, return_tensors="pt").to(torch_device) |
There was a problem hiding this comment.
Same here - parameters affecting output size have to be updated
| # to visualize self-attention on higher resolution images. | ||
| model = XCLIPModel.from_pretrained("microsoft/xclip-base-patch32").to(torch_device) | ||
|
|
||
| image_processor = XCLIPProcessor.from_pretrained("microsoft/xclip-base-patch32", size=480) |
There was a problem hiding this comment.
Same here:
- returns a processor
- needs to override crop size
- size and crop_size should be dicts
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
solves : #30579
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@amyeroberts
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.