Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update object detection with latest resize and pad strategies #30955

Merged
merged 5 commits into from
May 22, 2024

Conversation

qubvel
Copy link
Member

@qubvel qubvel commented May 22, 2024

What does this PR do?

Updates object detection example and guide. It is now possible to use image_processor's resize and pad (#30742) instead of manual padding with albumentations. Despite image_processor resize being slower than albumenations I did not observe any degradation in training speed. Of course, it depends on data and hardware environment, but probably not too critical for not-so-fast detection models where bottleneck is GPU computations.

Before submitting

Who can review?

@amyeroberts

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@qubvel qubvel marked this pull request as draft May 22, 2024 09:55
@qubvel qubvel changed the title Update object detection with latest resize and pad strategies [WIP] Update object detection with latest resize and pad strategies May 22, 2024
@qubvel qubvel marked this pull request as ready for review May 22, 2024 10:33
@qubvel qubvel changed the title [WIP] Update object detection with latest resize and pad strategies Update object detection with latest resize and pad strategies May 22, 2024
Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating and running some speed tests!

@qubvel qubvel merged commit 15585b8 into huggingface:main May 22, 2024
8 checks passed
itazap pushed a commit that referenced this pull request May 24, 2024
* Update with new resizing and pad strategy

* Return pixel mask param

* Update inference in guide

* Fix empty compose

* Update guide
zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request Jun 11, 2024
…gface#30955)

* Update with new resizing and pad strategy

* Return pixel mask param

* Update inference in guide

* Fix empty compose

* Update guide
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants