Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ElectraForQuestionAnswering] fix qa example in doc #4929

Merged
merged 1 commit into from Jun 17, 2020

Conversation

patil-suraj
Copy link
Contributor

This PR fixes the QA example in the doc for ElectraForQuestionAnswering. In the last example token_type_ids were not used, this PR fixes that

@sgugger

@codecov
Copy link

codecov bot commented Jun 11, 2020

Codecov Report

Merging #4929 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4929   +/-   ##
=======================================
  Coverage   77.10%   77.11%           
=======================================
  Files         128      128           
  Lines       21723    21723           
=======================================
+ Hits        16749    16751    +2     
+ Misses       4974     4972    -2     
Impacted Files Coverage Δ
src/transformers/modeling_electra.py 78.16% <ø> (ø)
src/transformers/file_utils.py 73.38% <0.00%> (-0.41%) ⬇️
src/transformers/modeling_utils.py 90.61% <0.00%> (+0.11%) ⬆️
src/transformers/modeling_transfo_xl.py 78.81% <0.00%> (+0.19%) ⬆️
src/transformers/trainer.py 39.48% <0.00%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e80d6c6...4a895d8. Read the comment docs.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sgugger sgugger requested a review from LysandreJik June 11, 2020 11:58
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LysandreJik LysandreJik merged commit fb6cccb into huggingface:master Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants