Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert hans to Trainer #5025

Merged
merged 2 commits into from Jun 16, 2020
Merged

Convert hans to Trainer #5025

merged 2 commits into from Jun 16, 2020

Conversation

sgugger
Copy link
Collaborator

@sgugger sgugger commented Jun 15, 2020

This follows up from #4854 (@julien-c I took all your comments into account) and will close #4742.

@codecov
Copy link

codecov bot commented Jun 15, 2020

Codecov Report

Merging #5025 into master will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5025      +/-   ##
==========================================
- Coverage   77.18%   77.09%   -0.10%     
==========================================
  Files         128      128              
  Lines       21877    21877              
==========================================
- Hits        16886    16866      -20     
- Misses       4991     5011      +20     
Impacted Files Coverage Δ
src/transformers/modeling_xlnet.py 76.35% <0.00%> (-2.30%) ⬇️
src/transformers/modeling_tf_utils.py 85.86% <0.00%> (-1.40%) ⬇️
src/transformers/modeling_utils.py 90.73% <0.00%> (+0.23%) ⬆️
src/transformers/file_utils.py 73.79% <0.00%> (+0.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bf4098...201fae2. Read the comment docs.

Copy link
Member

@julien-c julien-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Don't forget to fill a checkmark into the Big Table of Tasks 😉

@sgugger sgugger merged commit d5477ba into huggingface:master Jun 16, 2020
@sgugger sgugger deleted the hans_trainer branch June 16, 2020 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Perform evaluation on HANS with Trainer (like GLUE example)
2 participants