Fix marian tokenizer save pretrained #5043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5043 +/- ##
=======================================
Coverage 77.36% 77.37%
=======================================
Files 130 130
Lines 21989 21990 +1
=======================================
+ Hits 17012 17014 +2
+ Misses 4977 4976 -1
Continue to review full report at Codecov.
|
| def test_tokenizer_equivalence_en_de(self): | ||
| en_de_tokenizer = MarianTokenizer.from_pretrained(f"{ORG_NAME}opus-mt-en-de") | ||
| batch = en_de_tokenizer.prepare_translation_batch(["I am a small frog"], return_tensors=None) | ||
| self.assertIsInstance(batch, BatchEncoding) | ||
| expected = [38, 121, 14, 697, 38848, 0] | ||
| self.assertListEqual(expected, batch.input_ids[0]) | ||
|
|
||
| save_dir = tempfile.mkdtemp() |
There was a problem hiding this comment.
nit I guess, but I like the context manager approach better:
with tempfile.TemporaryDirectory() as tmp_dir:
....| @@ -60,10 +60,15 @@ def get_input_output_texts(self, tokenizer): | |||
| "This is a test", | |||
| ) | |||
|
|
|||
| @slow | |||
| def test_tokenizer_equivalence_en_de(self): | |||
| en_de_tokenizer = MarianTokenizer.from_pretrained(f"{ORG_NAME}opus-mt-en-de") | |||
| batch = en_de_tokenizer.prepare_translation_batch(["I am a small frog"], return_tensors=None) | |||
| self.assertIsInstance(batch, BatchEncoding) | |||
| expected = [38, 121, 14, 697, 38848, 0] | |||
There was a problem hiding this comment.
Would be nice to write the expected result as a comment for better readability
patrickvonplaten
approved these changes
Jun 16, 2020
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.