Add pad_to_multiple_of on tokenizers (reimport) #5054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5054 +/- ##
==========================================
+ Coverage 79.08% 79.09% +0.01%
==========================================
Files 138 138
Lines 24078 24081 +3
==========================================
+ Hits 19041 19047 +6
+ Misses 5037 5034 -3
Continue to review full report at Codecov.
|
thomwolf
force-pushed
the
pad_to_multiple_of_v2
branch
from
15f8c2a
to
1179cc8
Compare
jplu
pushed a commit
to jplu/transformers
that referenced
this pull request
Jun 29, 2020
* Add new parameter `pad_to_multiple_of` on tokenizers. * unittest for pad_to_multiple_of * Add .name when logging enum. * Fix missing .items() on dict in tests. * Add special check + warning if the tokenizer doesn't have proper pad_token. * Use the correct logger format specifier. * Ensure tokenizer with no pad_token do not modify the underlying padding strategy. * Skip test if tokenizer doesn't have pad_token * Fix RobertaTokenizer on empty input * Format. Signed-off-by: Morgan Funtowicz <funtowiczmo@gmail.com> * fix and updating to simpler API Co-authored-by: Thomas Wolf <thomwolf@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reimported from #4731.
Introduce
pad_to_multiple_ofon both slow and fast tokenizers. This parameter introduces the "bucketizaton behaviour" also refered as Shape Polymorphism.This is especially usefull when targetting NN dedicated accelerators such as:
Bonus:
text[0].is_space()would crash (RobertaTokenizer corner case with empty string #3608).Edit (@thomwolf):
ValueErrorif you want to truncation to a length which is not a multiple ofpad_to_multiple_of