Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TF auto model to the docs + fix sphinx warnings (again) #5187

Merged
merged 1 commit into from Jun 22, 2020
Merged

Add TF auto model to the docs + fix sphinx warnings (again) #5187

merged 1 commit into from Jun 22, 2020

Conversation

sgugger
Copy link
Collaborator

@sgugger sgugger commented Jun 22, 2020

The goal of this PR was just to add the automodel to the docs (as pointed out in #5145) but then I had 100 sphinx warnings that made me grumpy so I had to fix them (some of them from the auto model docs, but most of them from #4978).

As usual a few of them were harmless, others had a real impact on the docs, so I think we should make sure in the CI that there are no sphinx warnings to avoid making the docs bad by mistake.

@codecov
Copy link

codecov bot commented Jun 22, 2020

Codecov Report

Merging #5187 into master will decrease coverage by 0.89%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5187      +/-   ##
==========================================
- Coverage   77.99%   77.10%   -0.90%     
==========================================
  Files         138      138              
  Lines       23772    23772              
==========================================
- Hits        18541    18329     -212     
- Misses       5231     5443     +212     
Impacted Files Coverage Δ
src/transformers/modeling_albert.py 80.43% <ø> (ø)
src/transformers/modeling_bart.py 96.23% <ø> (ø)
src/transformers/modeling_bert.py 87.50% <ø> (ø)
src/transformers/modeling_ctrl.py 99.14% <ø> (ø)
src/transformers/modeling_distilbert.py 97.70% <ø> (ø)
src/transformers/modeling_electra.py 80.19% <ø> (ø)
src/transformers/modeling_flaubert.py 84.12% <ø> (ø)
src/transformers/modeling_gpt2.py 85.43% <ø> (ø)
src/transformers/modeling_longformer.py 93.04% <ø> (ø)
src/transformers/modeling_mobilebert.py 88.78% <ø> (ø)
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebc3610...cca9865. Read the comment docs.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool! Thanks for taking care of the warnings, I'm opening a PR for the test failing on error right now.

@sgugger sgugger merged commit 1262495 into huggingface:master Jun 22, 2020
@sgugger sgugger deleted the tfauto_doc branch June 22, 2020 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants