-
Notifications
You must be signed in to change notification settings - Fork 25.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] fix model_doc links in model summary #5566
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5566 +/- ##
==========================================
+ Coverage 77.20% 77.55% +0.35%
==========================================
Files 141 141
Lines 24638 24638
==========================================
+ Hits 19021 19108 +87
+ Misses 5617 5530 -87
Continue to review full report at Codecov.
|
No, this won't work across versions (if you switch to master docs for instance). The problem is in the first slash, I think removing it should be enough to make all link works. |
Double-checked locally, this is the right fix: |
should I make these changes ? also model_doc/gpt or model_doc/gpt.html ? |
No need for the .html. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
How much time does it take to these changes be reflected in the website? Also, can I close my issue after this fix? Thanks! :) |
The thing is that the bug will probably stay in the stable version of the doc forever (unless we manage to cherry-pick it somehow @LysandreJik ?). It is reflected in the master version already. You can close your issue whenever you like :-) |
* fix model_doc links * update model links
Possible fix for #5561
@sgugger