[AutoModels] Fix config params handling of all PT and TF AutoModels #5665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickvonplaten
requested review from
LysandreJik and
sgugger
and removed request for
LysandreJik
1 task
|
Isn't the canonical way: in the test? |
Codecov Report
@@ Coverage Diff @@
## master #5665 +/- ##
==========================================
- Coverage 78.43% 77.32% -1.12%
==========================================
Files 146 146
Lines 26002 26002
==========================================
- Hits 20395 20105 -290
- Misses 5607 5897 +290
Continue to review full report at Codecov.
|
Oh yeah, that's much cleaner. We should probably update all AutoModels in PT and TF with this then, no? |
|
I think that's correct, and the way it was always meant to be 🤨 |
Yes, I agree. |
patrickvonplaten
force-pushed
the
fix_auto_model_with_config_kwargs
branch
from
754d5e2
to
873887a
Compare
patrickvonplaten
changed the title
This was referenced Jul 27, 2020
LoicGrobol
added a commit
to hopsparser/hopsparser
that referenced
this pull request
Nov 9, 2020
(transformers >3.1.0 fixed the config kwargs handling in huggingface/transformers#5665 )
LoicGrobol
added a commit
to hopsparser/hopsparser
that referenced
this pull request
Nov 9, 2020
(transformers >3.1.0 fixed the config kwargs handling in huggingface/transformers#5665 )
LoicGrobol
added a commit
to hopsparser/hopsparser
that referenced
this pull request
Nov 11, 2020
(transformers >3.1.0 fixed the config kwargs handling in huggingface/transformers#5665 )
LoicGrobol
added a commit
to hopsparser/hopsparser
that referenced
this pull request
Nov 12, 2020
(transformers >3.1.0 fixed the config kwargs handling in huggingface/transformers#5665 )
LoicGrobol
added a commit
to hopsparser/hopsparser
that referenced
this pull request
Nov 12, 2020
(transformers >3.1.0 fixed the config kwargs handling in huggingface/transformers#5665 )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As shown in #5474, currently, a command like:
fails because
is_decoderis carried on as a model init argument even though it should only be used as a config init argument.This PR fixes one
AutoModelFor....for this, but this still has be applied for otherAutoModelFor...classes.Pinging @LysandreJik @sgugger @thomwolf - are you guys ok with this change (bug fix) in general?