Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[squad] add version tag to squad cache #5669

Merged
merged 1 commit into from
Jul 10, 2020

Conversation

lazovich
Copy link
Contributor

This diff is to add a version number to the SQuAD cache file so that cached SQuADv1.1 features are not mistakenly read when you request SQuADv2. Addresses #5668

@codecov
Copy link

codecov bot commented Jul 10, 2020

Codecov Report

Merging #5669 into master will increase coverage by 0.52%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5669      +/-   ##
==========================================
+ Coverage   77.01%   77.53%   +0.52%     
==========================================
  Files         128      145      +17     
  Lines       21615    25367    +3752     
==========================================
+ Hits        16646    19668    +3022     
- Misses       4969     5699     +730     
Impacted Files Coverage Δ
src/transformers/__init__.py 99.24% <ø> (+0.11%) ⬆️
src/transformers/benchmark/benchmark.py 74.01% <ø> (+5.16%) ⬆️
src/transformers/benchmark/benchmark_args.py 86.04% <ø> (+0.68%) ⬆️
src/transformers/benchmark/benchmark_args_tf.py 87.50% <ø> (ø)
src/transformers/benchmark/benchmark_args_utils.py 89.13% <ø> (-7.75%) ⬇️
src/transformers/benchmark/benchmark_tf.py 61.53% <ø> (ø)
src/transformers/benchmark/benchmark_utils.py 69.84% <ø> (-3.26%) ⬇️
src/transformers/configuration_albert.py 100.00% <ø> (ø)
src/transformers/configuration_auto.py 93.18% <ø> (+0.32%) ⬆️
src/transformers/configuration_bart.py 93.75% <ø> (+0.41%) ⬆️
... and 118 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfacb2e...77a74f7. Read the comment docs.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, thanks!

@LysandreJik LysandreJik merged commit cdf4cd7 into huggingface:master Jul 10, 2020
abelriboulot pushed a commit to abelriboulot/transformers that referenced this pull request Jul 11, 2020
…ate_convert_to_onnx

* 'master' of github.com:huggingface/transformers: (29 commits)
  Add Microsoft's CodeBERT (huggingface#5683)
  Document model outputs (huggingface#5673)
  Deprecate old past arguments (huggingface#5671)
  [squad] add version tag to squad cache (huggingface#5669)
  Add Reformer to notebooks
  Update The Big Table of Tasks
  Update README.md (huggingface#5617)
  Create README.md (huggingface#5572)
  Create README.md for electra-base-squad2 (huggingface#5574)
  Add freshly trained `base` version (huggingface#5621)
  Fixed use of memories in XLNet (caching for language generation + warning when loading improper memoryless model) (huggingface#5632)
  Create README.md (huggingface#5638)
  Create model card (huggingface#5655)
  Create README.md - Model card (huggingface#5657)
  Create README.md - Model card (huggingface#5658)
  Change model outputs types to self-document outputs (huggingface#5438)
  Create Model card for RoBERTa-hindi-guj-san (huggingface#5661)
  Improvements to PretrainedConfig documentation (huggingface#5642)
  [model_card] BART for ELI5
  Create README.md (huggingface#5652)
  ...

� Conflicts:
�	src/transformers/convert_graph_to_onnx.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants