Fix Trainer in DataParallel setting #5685
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new output types seem to break data parallel FYI, see comment on #5671. This is is because of the line
in
scatter_gather
which tries to reconstruct an output of the same type as ours (and fails since it does not provide the necessary arguments). There is no way to fix ourModelOutput
to work with this AFAICT.However, we have the
return_tuple
argument to fix the issue :-)