[ModelOutput] Proposal to fix compatibility issue with torch.DataParallel #5740
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal to fix #5693 by making
ModelOutput
inherit from a dictionary and behave like a dictionary on iteration (i.e. iterate over the keys rather than the values).This could break backward compatibility when users iterates over the output tuple rather than indexing it.
On the other hand, we regain backward compatibility with
torch.DataParallel
and from a more general design point of view theModelOutput
class should probably be closer to a dictionary than a tuple in the future.