Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] seq2seq pack_dataset.py actually packs #5913

Merged
merged 1 commit into from
Jul 20, 2020
Merged

[Fix] seq2seq pack_dataset.py actually packs #5913

merged 1 commit into from
Jul 20, 2020

Conversation

sshleifer
Copy link
Contributor

Added stronger test (that failed before small code fixes).

@sshleifer sshleifer linked an issue Jul 20, 2020 that may be closed by this pull request
Fix pack_dataset.py #5898
Closed
@sshleifer sshleifer added this to In progress in Examples/seq2seq via automation Jul 20, 2020
sshleifer
sshleifer commented Jul 20, 2020
View reviewed changes
Copy link
Contributor Author

@sshleifer sshleifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jul 20, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@f197511). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5913   +/-   ##
=========================================
  Coverage          ?   78.69%           
=========================================
  Files             ?      146           
  Lines             ?    26214           
  Branches          ?        0           
=========================================
  Hits              ?    20629           
  Misses            ?     5585           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f197511...547c2ad. Read the comment docs.

@sshleifer sshleifer changed the title [Fix] seq2seq pack_dataset.py was not packing because of extra newlines [Fix] seq2seq pack_dataset.py actually packs Jul 20, 2020
@sshleifer sshleifer merged commit f1a4e06 into huggingface:master Jul 20, 2020
Examples/seq2seq automation moved this from In progress to Done Jul 20, 2020
@sshleifer sshleifer deleted the fix-pack-dataset branch July 20, 2020 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
Examples/seq2seq
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix pack_dataset.py
1 participant
@sshleifer