Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

seq2seq/run_eval.py can take decoder_start_token_id #5949

Merged
merged 3 commits into from
Jul 21, 2020

Conversation

sshleifer
Copy link
Contributor

@sshleifer sshleifer commented Jul 21, 2020

Also: batch_decode: document kwargs for autocomplete

@sshleifer sshleifer changed the title batch_decode: document kwargs for autocomplete seq2seq/run_eval.py can take decoder_start_token_id from command line Jul 21, 2020
@sshleifer sshleifer requested a review from sgugger July 21, 2020 20:27
@codecov
Copy link

codecov bot commented Jul 21, 2020

Codecov Report

Merging #5949 into master will decrease coverage by 0.17%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5949      +/-   ##
==========================================
- Coverage   78.69%   78.51%   -0.18%     
==========================================
  Files         146      146              
  Lines       26214    26214              
==========================================
- Hits        20628    20581      -47     
- Misses       5586     5633      +47     
Impacted Files Coverage Δ
src/transformers/tokenization_utils_base.py 93.60% <50.00%> (ø)
src/transformers/modeling_tf_electra.py 26.02% <0.00%> (-69.52%) ⬇️
src/transformers/generation_utils.py 96.82% <0.00%> (-0.29%) ⬇️
src/transformers/modeling_tf_distilbert.py 98.79% <0.00%> (+33.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95d1962...450d753. Read the comment docs.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docstring of batch_decode could be better, but I'll soon do a swipe other this file so that's ok for now.

@sshleifer sshleifer changed the title seq2seq/run_eval.py can take decoder_start_token_id from command line seq2seq/run_eval.py can take decoder_start_token_id Jul 21, 2020
@sshleifer sshleifer merged commit 9dab39f into huggingface:master Jul 21, 2020
@sshleifer sshleifer deleted the fix_run_eval branch July 21, 2020 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants