Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MbartTokenizer: do not hardcode vocab size #5998

Merged
merged 4 commits into from
Jul 23, 2020

Conversation

sshleifer
Copy link
Contributor

@sshleifer sshleifer commented Jul 23, 2020

language codes should start at the end of the standard vocab. If the standard vocab is smaller, this number is not 250,001.

@codecov
Copy link

codecov bot commented Jul 23, 2020

Codecov Report

Merging #5998 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5998   +/-   ##
=======================================
  Coverage   78.48%   78.49%           
=======================================
  Files         146      146           
  Lines       26230    26232    +2     
=======================================
+ Hits        20587    20591    +4     
+ Misses       5643     5641    -2     
Impacted Files Coverage Δ
src/transformers/tokenization_bart.py 95.58% <100.00%> (+0.13%) ⬆️
src/transformers/generation_tf_utils.py 86.71% <0.00%> (+0.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33d7506...39fdead. Read the comment docs.

@sshleifer sshleifer requested a review from sgugger July 23, 2020 17:55
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sshleifer sshleifer merged commit 9827d66 into huggingface:master Jul 23, 2020
@sshleifer sshleifer deleted the mbart-trimmed branch July 23, 2020 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants