Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new AutoModel classes in pipeline #6062

Merged
merged 2 commits into from
Jul 27, 2020

Conversation

patil-suraj
Copy link
Contributor

This PR removes the about to be deprecated AutModelWithLMHead class and uses the new AutoModelForSeq2SeqLM, AutoModelForCausalLM and AutoModelForMaskedLM for translation, text-generation and fill-mask pipelines respectively.

Regrading issue #6060

@sgugger

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is cleaner, thanks for tackling this!

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@codecov
Copy link

codecov bot commented Jul 27, 2020

Codecov Report

Merging #6062 into master will increase coverage by 0.17%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6062      +/-   ##
==========================================
+ Coverage   78.50%   78.67%   +0.17%     
==========================================
  Files         146      146              
  Lines       26251    26251              
==========================================
+ Hits        20609    20654      +45     
+ Misses       5642     5597      -45     
Impacted Files Coverage Δ
src/transformers/pipelines.py 77.00% <100.00%> (ø)
src/transformers/modeling_tf_distilbert.py 64.90% <0.00%> (-33.90%) ⬇️
src/transformers/generation_tf_utils.py 83.95% <0.00%> (-1.51%) ⬇️
src/transformers/file_utils.py 81.19% <0.00%> (-0.30%) ⬇️
src/transformers/generation_utils.py 96.82% <0.00%> (-0.29%) ⬇️
src/transformers/modeling_auto.py 78.48% <0.00%> (+4.06%) ⬆️
src/transformers/modeling_tf_electra.py 95.53% <0.00%> (+69.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7f03b2...6385c16. Read the comment docs.

@sgugger sgugger merged commit c8bdf7f into huggingface:master Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants