Fix FlauBERT GPU test #6142
Fix FlauBERT GPU test #6142
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6142 +/- ##
==========================================
- Coverage 78.35% 78.32% -0.04%
==========================================
Files 146 146
Lines 26403 26403
==========================================
- Hits 20689 20679 -10
- Misses 5714 5724 +10
Continue to review full report at Codecov.
|
| if lengths is None: | ||
| if input_ids is not None: | ||
| lengths = (input_ids != self.pad_index).sum(dim=1).long() | ||
| else: | ||
| lengths = torch.LongTensor([slen] * bs) | ||
| lengths = torch.tensor([slen] * bs, device=device) |
There was a problem hiding this comment.
LongTensor isn't a factory to create tensors, but the tensor class, so you can't directly set the device type on it. You would have to do:
lengths = torch.LongTensor([slen] * bs).to(device)If I understand correctly, this first creates the tensor on the CPU, before creating a new one on the updated device (if the device is different). When using the factory method, I believe it's only created once, and is therefore more efficient. I didn't check the source code directly though so I may be wrong.
There was a problem hiding this comment.
Makes sense, thanks for clarifying!
No description provided.