Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tf trainer cleanup #6143

Merged
merged 4 commits into from
Jul 30, 2020
Merged

Tf trainer cleanup #6143

merged 4 commits into from
Jul 30, 2020

Conversation

sgugger
Copy link
Collaborator

@sgugger sgugger commented Jul 29, 2020

New version of #6015

Will harmonize the public customization hooks and document everything properly once this is merged.

@sgugger sgugger requested review from jplu and LysandreJik July 29, 2020 20:37
@codecov
Copy link

codecov bot commented Jul 29, 2020

Codecov Report

Merging #6143 into master will increase coverage by 1.02%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6143      +/-   ##
==========================================
+ Coverage   78.35%   79.38%   +1.02%     
==========================================
  Files         146      146              
  Lines       26403    26416      +13     
==========================================
+ Hits        20689    20970     +281     
+ Misses       5714     5446     -268     
Impacted Files Coverage Δ
src/transformers/trainer_tf.py 16.14% <25.00%> (-0.41%) ⬇️
src/transformers/modeling_tf_gpt2.py 65.42% <0.00%> (-29.91%) ⬇️
src/transformers/tokenization_marian.py 68.14% <0.00%> (-25.67%) ⬇️
src/transformers/tokenization_xlnet.py 66.66% <0.00%> (-23.43%) ⬇️
src/transformers/file_utils.py 82.20% <0.00%> (-0.29%) ⬇️
src/transformers/generation_tf_utils.py 85.96% <0.00%> (-0.26%) ⬇️
src/transformers/modeling_tf_mobilebert.py 96.77% <0.00%> (+73.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54f9fbe...46b6cb4. Read the comment docs.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, this is clean. LGTM, love the warnings.

Copy link
Contributor

@jplu jplu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sgugger sgugger merged commit 562b636 into master Jul 30, 2020
@sgugger sgugger deleted the tf_trainer_cleanup branch July 30, 2020 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants