[s2s] add support for overriding config params #6149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p 0.1 --dropout 0.1 --attention_dropout 0.1
Codecov Report
@@ Coverage Diff @@
## master #6149 +/- ##
==========================================
+ Coverage 78.35% 79.68% +1.32%
==========================================
Files 146 146
Lines 26403 26403
==========================================
+ Hits 20689 21039 +350
+ Misses 5714 5364 -350
Continue to review full report at Codecov.
|
- optional - goes into model.config
sshleifer
reviewed
Jul 30, 2020
There was a problem hiding this comment.
Can you add test cases:
- good case where model.config has the new value
- case (T5) that hits your assert. its called
dropout_ratein t5. We can expose that or leave it for future work.
I'm surprised you didn't need to change the CHEAP_ARGS constant in the tests.
|
The code looks perfect. |
stas00
changed the title
because the new args are optional? Unless you mean something else. ...Working on the tests. |
|
Added tests as suggested. |
sshleifer
changed the title
|
good alias sty () {
make style
flake8 examples templates tests src utils
} |
stas00
added a commit
to stas00/transformers
that referenced
this pull request
Aug 1, 2020
this is a follow up to huggingface#6149 - there was no need to add newly added options to finetune.sh - reverted that change - added a hint to users how to get all the options (--help)
This was referenced Aug 1, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add support for overriding model params:
as requested at #6018
README.mdseems to be mostly the editor removing superfluous whitespace - not sure why github shows it - normally it doesn't. The only added doc section is https://github.com/stas00/transformers/blob/seq2seq-train_params-1/examples/seq2seq/README.md#finetuning-training-params