Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model output test #6155

Merged
merged 2 commits into from
Jul 31, 2020
Merged

Model output test #6155

merged 2 commits into from
Jul 31, 2020

Conversation

sgugger
Copy link
Collaborator

@sgugger sgugger commented Jul 30, 2020

Step 2 of the strategy for the new model outputs as outlined on the forum.
Use the return_dict argument introduced in #6138 in all tests and remove all unpacking from the tests.

@codecov
Copy link

codecov bot commented Jul 30, 2020

Codecov Report

Merging #6155 into master will increase coverage by 0.10%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6155      +/-   ##
==========================================
+ Coverage   78.35%   78.46%   +0.10%     
==========================================
  Files         146      146              
  Lines       26454    26454              
==========================================
+ Hits        20729    20758      +29     
+ Misses       5725     5696      -29     
Impacted Files Coverage Δ
src/transformers/modeling_encoder_decoder.py 92.20% <ø> (ø)
src/transformers/modeling_openai.py 82.25% <66.66%> (-0.38%) ⬇️
src/transformers/modeling_reformer.py 95.49% <100.00%> (-0.21%) ⬇️
src/transformers/modeling_tf_flaubert.py 24.22% <0.00%> (-63.98%) ⬇️
src/transformers/modeling_longformer.py 89.21% <0.00%> (-2.24%) ⬇️
src/transformers/modeling_electra.py 81.55% <0.00%> (-0.29%) ⬇️
src/transformers/modeling_t5.py 83.71% <0.00%> (ø)
src/transformers/modeling_xlnet.py 81.75% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91cb954...33ebdb9. Read the comment docs.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impressive work, LGTM!

@sgugger sgugger merged commit d951c14 into master Jul 31, 2020
@sgugger sgugger deleted the model_output_test branch July 31, 2020 13:44
Mehrad0711 pushed a commit to Mehrad0711/transformers that referenced this pull request Aug 3, 2020
* Use return_dict=True in all tests

* Formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants