-
Notifications
You must be signed in to change notification settings - Fork 25.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc pipelines #6175
Doc pipelines #6175
Conversation
Generative models | ||
~~~~~~~~~~~~~~~~~ | ||
|
||
Coming soon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will be my next PR doc, but I needed the anchor to make a link in several docstrings of Pipeline subclasses.
|
||
TokenClassificationPipeline | ||
ConversationalPipeline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a reorderin by alphabetical order and put the main Pipeline class at the end since it's more abstract.
@@ -408,7 +497,7 @@ def __init__( | |||
): | |||
|
|||
if framework is None: | |||
framework = get_framework() | |||
framework = get_framework(model) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is what the pipeline
function does, seemed good to do it too, in case a user is directly using the subclasses.
Codecov Report
@@ Coverage Diff @@
## master #6175 +/- ##
=======================================
Coverage 79.51% 79.52%
=======================================
Files 146 146
Lines 26607 26618 +11
=======================================
+ Hits 21156 21167 +11
Misses 5451 5451
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
Lysandre comments Co-authored-by: Lysandre Debut <lysandre@huggingface.co>
* Init work on pipelines doc * Work in progress * Work in progress * Doc pipelines * Rm unwanted default * Apply suggestions from code review Lysandre comments Co-authored-by: Lysandre Debut <lysandre@huggingface.co> Co-authored-by: Lysandre Debut <lysandre@huggingface.co>
Continue the improvement of the main classes documentation with pipelines.
Preview of the new pipeline page.
Preview of the new pipeline utils page.