-
Notifications
You must be signed in to change notification settings - Fork 25.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Encoder decoder config docs #6195
Encoder decoder config docs #6195
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6195 +/- ##
==========================================
+ Coverage 79.47% 79.80% +0.32%
==========================================
Files 146 146
Lines 26607 26607
==========================================
+ Hits 21146 21233 +87
+ Misses 5461 5374 -87
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Example of the model can be simplified => no need to set decoder = True
, since this is done automatically.
model file should only show examples for how to load save model
@afcruzs - thanks a lot for your PR. I changed the examples a bit trying to make sure:
sorry for meddling in your PR. |
Thanks for improving the examples! I've fixed the whitespace issue |
As discussed on #5826, this PR adds more details on how to load encoder/decoder config objects from pretrained folders and how to instantiate encoder_decoder pretrained models given their corresponding configuration objects (useful for loading pre-trained models and modifying some config members for fine-tuning).