Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setup for TPU CI to run every hour. #6219

Merged
merged 2 commits into from
Aug 7, 2020
Merged

Add setup for TPU CI to run every hour. #6219

merged 2 commits into from
Aug 7, 2020

Conversation

zcain117
Copy link
Contributor

@zcain117 zcain117 commented Aug 3, 2020

Use GKE to run TPU CI testing once per hour using latest code in master branch.

@zcain117
Copy link
Contributor Author

zcain117 commented Aug 3, 2020

From previous PR:

LysandreJik 4 hours ago Member
Shouldn't the bert-based-case and bertBasedCase be bert-base-cased and bertBaseCased?

By the way, why is this model specific? Are we using these values somewhere?

zcain117 19 minutes ago Author
Fixed that typo.

The local bertBasedCase is just a name of that jsonnet variable, it just needs to be a unique string but several punctuation marks are not allowed in variable names. We recommend 1 variable like this per test. On our team we have 1 file per "family" of tests, e.g. 1 file for pytorch resnet50 where the file contains [short test, long test] X [v2-8 TPU, v3-8 TPU, v100 GPU(s)] for the same model on the same ML framework.

The modelName and frameworkPrefix are just used in generating the name of the GKE job. For example, a recent run was named: hf-bert-based-case-example-v3-8-vtgrj. Future runs will look like hf-bert-base-cased-example-v3-8-xxxxx

@codecov
Copy link

codecov bot commented Aug 3, 2020

Codecov Report

Merging #6219 into master will decrease coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6219      +/-   ##
==========================================
- Coverage   78.54%   78.44%   -0.11%     
==========================================
  Files         148      146       -2     
  Lines       27196    26586     -610     
==========================================
- Hits        21361    20855     -506     
+ Misses       5835     5731     -104     
Impacted Files Coverage Δ
src/transformers/modeling_tf_flaubert.py 24.22% <0.00%> (-63.51%) ⬇️
src/transformers/trainer_utils.py 85.71% <0.00%> (-14.29%) ⬇️
src/transformers/modeling_tf_albert.py 76.73% <0.00%> (-5.02%) ⬇️
src/transformers/file_utils.py 80.05% <0.00%> (-2.14%) ⬇️
src/transformers/modeling_tf_mobilebert.py 23.58% <0.00%> (-0.97%) ⬇️
src/transformers/modeling_electra.py 81.55% <0.00%> (-0.58%) ⬇️
src/transformers/pipelines.py 79.36% <0.00%> (-0.43%) ⬇️
src/transformers/modeling_tf_utils.py 86.97% <0.00%> (-0.33%) ⬇️
src/transformers/modeling_reformer.py 95.49% <0.00%> (-0.20%) ⬇️
src/transformers/training_args.py 80.19% <0.00%> (-0.20%) ⬇️
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6695450...6e4a41b. Read the comment docs.

@LysandreJik LysandreJik self-requested a review August 4, 2020 06:09
@zcain117
Copy link
Contributor Author

zcain117 commented Aug 5, 2020

@LysandreJik let me know if there's anything else you can think of here

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-organized the template a bit and set to run once per dey. Thanks a lot @zcain117!

@LysandreJik LysandreJik merged commit 1b8a7ff into huggingface:master Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants