Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the test now works again #6371

Merged
merged 1 commit into from
Aug 10, 2020
Merged

Conversation

stas00
Copy link
Contributor

@stas00 stas00 commented Aug 9, 2020

test_finetune_lr_shedulers can now run after #6358 was merged

@codecov
Copy link

codecov bot commented Aug 9, 2020

Codecov Report

Merging #6371 into master will increase coverage by 0.37%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6371      +/-   ##
==========================================
+ Coverage   79.34%   79.71%   +0.37%     
==========================================
  Files         148      148              
  Lines       27196    27196              
==========================================
+ Hits        21579    21680     +101     
+ Misses       5617     5516     -101     
Impacted Files Coverage Δ
src/transformers/modeling_tf_flaubert.py 24.53% <0.00%> (-63.20%) ⬇️
src/transformers/tokenization_openai.py 71.21% <0.00%> (-11.37%) ⬇️
src/transformers/tokenization_xlm_roberta.py 84.52% <0.00%> (-10.72%) ⬇️
src/transformers/generation_tf_utils.py 86.46% <0.00%> (-0.51%) ⬇️
src/transformers/tokenization_utils.py 90.40% <0.00%> (+0.40%) ⬆️
src/transformers/tokenization_bert.py 91.51% <0.00%> (+0.44%) ⬆️
src/transformers/tokenization_utils_fast.py 94.28% <0.00%> (+2.14%) ⬆️
src/transformers/tokenization_transfo_xl.py 42.48% <0.00%> (+3.75%) ⬆️
src/transformers/tokenization_utils_base.py 93.84% <0.00%> (+7.41%) ⬆️
src/transformers/tokenization_roberta.py 98.63% <0.00%> (+21.91%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e8a385...4d9d35c. Read the comment docs.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @stas00!

@LysandreJik LysandreJik merged commit 0830e79 into huggingface:master Aug 10, 2020
@stas00 stas00 deleted the ft_lr_shedulers branch August 10, 2020 16:30
sgugger added a commit that referenced this pull request Aug 11, 2020
* [wip] add get_polynomial_decay_schedule_with_warmup

* style

* add assert

* change lr_end to a much smaller default number

* check for exact equality

* [model_cards] electra-base-turkish-cased-ner (#6350)

* for electra-base-turkish-cased-ner

* Add metadata

Co-authored-by: Julien Chaumond <chaumond@gmail.com>

* Temporarily de-activate TPU CI

* Update modeling_tf_utils.py (#6372)

fix typo: ckeckpoint->checkpoint

* the test now works again (#6371)

* correct pl link in readme (#6364)

* refactor almost identical tests (#6339)

* refactor almost identical tests

* important to add a clear assert error message

* make the assert error even more descriptive than the original bt

* Small docfile fixes (#6328)

* Patch models (#6326)

* TFAlbertFor{TokenClassification, MultipleChoice}

* Patch models

* BERT and TF BERT info


s

* Update check_repo

* Ci GitHub caching (#6382)

* Cache Github Actions CI

* Remove useless file

* Colab button (#6389)

* Add colab button

* Add colab link for tutorials

* Fix links for open in colab (#6391)

* Update src/transformers/optimization.py

consistently use lr_end=1e-7 default

Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>

* [wip] add get_polynomial_decay_schedule_with_warmup

* style

* add assert

* change lr_end to a much smaller default number

* check for exact equality

* Update src/transformers/optimization.py

consistently use lr_end=1e-7 default

Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>

* remove dup (leftover from merge)

* convert the test into the new refactored format

* stick to using the current_step as is, without ++

Co-authored-by: M. Yusuf Sarıgöz <yusufsarigoz@gmail.com>
Co-authored-by: Julien Chaumond <chaumond@gmail.com>
Co-authored-by: Lysandre <lysandre.debut@reseau.eseo.fr>
Co-authored-by: Alexander Measure <ameasure@gmail.com>
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
Co-authored-by: Lysandre Debut <lysandre@huggingface.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants