Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn if debug requested without TPU fixes (#6308) #6390

Merged
merged 2 commits into from
Aug 11, 2020

Conversation

dmlap
Copy link
Contributor

@dmlap dmlap commented Aug 10, 2020

Check whether a PyTorch compatible TPU is available before attempting to print TPU metrics after training has completed. This way, users who apply --debug without reading the documentation aren't suprised by a stacktrace.

Check whether a PyTorch compatible TPU is available before attempting to print TPU metrics after training has completed. This way, users who apply `--debug` without reading the documentation aren't suprised by a stacktrace.
@dmlap
Copy link
Contributor Author

dmlap commented Aug 10, 2020

The CircleCI failures look like a pre-existing line length violation in trainer.py and a checksum mismatch downloading transformers itself for run_tests_torch. I don't believe either are related to my change – I was able to run the examples test suite locally and everything passed. I'd be happy to fix the line length issue, if that helps. I think it would take me awhile to figure out what's going on with the checksum mismatch.

@LysandreJik
Copy link
Member

Hi! There was an issue with the style in your PR, I pushed the fix. Will merge once all the tests are green!

@LysandreJik LysandreJik merged commit 87e124c into huggingface:master Aug 11, 2020
@LysandreJik
Copy link
Member

Thanks for your contribution :)

@dmlap
Copy link
Contributor Author

dmlap commented Aug 11, 2020

No problem! Thanks for the style-fixup, @LysandreJik.

fabiocapsouza added a commit to fabiocapsouza/transformers that referenced this pull request Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants