Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[examples] add pytest dependency #6425

Merged
merged 1 commit into from
Aug 11, 2020
Merged

[examples] add pytest dependency #6425

merged 1 commit into from
Aug 11, 2020

Conversation

sshleifer
Copy link
Contributor

@sshleifer sshleifer commented Aug 11, 2020 •
edited
Loading

Not really a new dependency, since already installed by pip install -e .[testing] but some examples users just run:

pip install -r examples/requirements.txt

so they don't have it, and tests break.

@sshleifer sshleifer linked an issue Aug 11, 2020 that may be closed by this pull request
seq2seq examples require pytest #6392
Closed
sgugger
sgugger approved these changes Aug 11, 2020
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@sshleifer sshleifer merged commit 3f071c4 into huggingface:master Aug 11, 2020
@sshleifer sshleifer deleted the examples-require-pytest branch August 11, 2020 21:58
LysandreJik
LysandreJik reviewed Aug 12, 2020
View reviewed changes
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

fabiocapsouza added a commit to fabiocapsouza/transformers that referenced this pull request Nov 15, 2020
@fabiocapsouza
Revert "[examples] add pytest dependency (huggingface#6425)"
7790f9f 
This reverts commit b559697.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LysandreJik LysandreJik LysandreJik left review comments

@sgugger sgugger sgugger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

seq2seq examples require pytest
3 participants
@sshleifer @LysandreJik @sgugger