Move prediction_loss_only to TrainingArguments #6426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6426 +/- ##
==========================================
- Coverage 79.90% 77.28% -2.63%
==========================================
Files 153 153
Lines 27877 27884 +7
==========================================
- Hits 22276 21549 -727
- Misses 5601 6335 +734
Continue to review full report at Codecov.
|
|
no strong opinion on this (but as usual consider the BC/cleanliness ratio carefully) |
fabiocapsouza
added a commit
to fabiocapsouza/transformers
that referenced
this pull request
Nov 15, 2020
)" This reverts commit b109ac3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It didn't make sense to me to have that boolean flag in the init of
Trainerwhen all the other ones are inTrainingArgumentsso I deprecated it and moved it.Let me know if you think it's a wrong move.
Unrelated changes: had to fix
make qualitythat was complaining about non-documented or tested models and it was easier to fix them than change my setup (which doesn't let me push if make quality fails).