Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] make the text more readable, fix some typos, add some disambiguation #6508

Merged
merged 2 commits into from
Aug 17, 2020

Conversation

stas00
Copy link
Contributor

@stas00 stas00 commented Aug 15, 2020

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Just one nit, I'll let you decide to include it or not before merging.

docs/source/glossary.rst Outdated Show resolved Hide resolved
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Aug 17, 2020

Codecov Report

Merging #6508 into master will increase coverage by 0.16%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6508      +/-   ##
==========================================
+ Coverage   80.37%   80.54%   +0.16%     
==========================================
  Files         156      156              
  Lines       28058    28058              
==========================================
+ Hits        22552    22599      +47     
+ Misses       5506     5459      -47     
Impacted Files Coverage Δ
src/transformers/configuration_utils.py 95.91% <ø> (-0.69%) ⬇️
src/transformers/generation_tf_utils.py 86.46% <ø> (ø)
src/transformers/generation_utils.py 96.94% <ø> (ø)
src/transformers/trainer.py 37.84% <0.00%> (ø)
src/transformers/tokenization_xlm_roberta.py 84.52% <0.00%> (-10.72%) ⬇️
src/transformers/tokenization_dpr.py 53.15% <0.00%> (-4.51%) ⬇️
src/transformers/tokenization_auto.py 95.55% <0.00%> (-2.23%) ⬇️
src/transformers/pipelines.py 79.94% <0.00%> (+0.25%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24107c2...76e7b5c. Read the comment docs.

@sgugger sgugger merged commit 84d3331 into huggingface:master Aug 17, 2020
@stas00 stas00 deleted the typos branch August 17, 2020 15:21
Zigur pushed a commit to Zigur/transformers that referenced this pull request Oct 26, 2020
…ation (huggingface#6508)

* [doc] make the text more readable, fix some typos, add some disambiguation

* Update docs/source/glossary.rst

Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>

Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
fabiocapsouza pushed a commit to fabiocapsouza/transformers that referenced this pull request Nov 15, 2020
…ation (huggingface#6508)

* [doc] make the text more readable, fix some typos, add some disambiguation

* Update docs/source/glossary.rst

Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>

Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
fabiocapsouza added a commit to fabiocapsouza/transformers that referenced this pull request Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants