fix incorrect codecov reports #6553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed at huggingface#6317 codecov currently sends an invalid report when it fails to find a code coverage report for the base it checks against, so this gets fixed by: - require_base: yes # don't report if there is no base coverage report let's add this for clarity, this supposedly is already the default. - require_head: yes # don't report if there is no head coverage report and perhaps no point reporting on doc changes as they don't make any difference and it just generates noise: - require_changes: true # only comment if there was change in coverage
sgugger
approved these changes
Aug 18, 2020
|
Great, thanks for diving into it @stas00! |
|
Alas, it solved only part of the problem - the main issue is still there #6553 :( |
Zigur
pushed a commit
to Zigur/transformers
that referenced
this pull request
Oct 26, 2020
As discussed at huggingface#6317 codecov currently sends an invalid report when it fails to find a code coverage report for the base it checks against, so this gets fixed by: - require_base: yes # don't report if there is no base coverage report let's add this for clarity, this supposedly is already the default. - require_head: yes # don't report if there is no head coverage report and perhaps no point reporting on doc changes as they don't make any difference and it just generates noise: - require_changes: true # only comment if there was change in coverage
fabiocapsouza
pushed a commit
to fabiocapsouza/transformers
that referenced
this pull request
Nov 15, 2020
As discussed at huggingface#6317 codecov currently sends an invalid report when it fails to find a code coverage report for the base it checks against, so this gets fixed by: - require_base: yes # don't report if there is no base coverage report let's add this for clarity, this supposedly is already the default. - require_head: yes # don't report if there is no head coverage report and perhaps no point reporting on doc changes as they don't make any difference and it just generates noise: - require_changes: true # only comment if there was change in coverage
fabiocapsouza
added a commit
to fabiocapsouza/transformers
that referenced
this pull request
Nov 15, 2020
This reverts commit c9d26c1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed at #6317 codecov currently sends an invalid report when it fails to find a code coverage report for the base it checks against. When this happens it goes looking for the nearest hash with report, which often leads to a report that is not representative of the true impact of the proposed PR.
This PR fixes it by adding:
require_base: yes# don't report if there is no base coverage reportAnd then:
let's add this for clarity, this supposedly is already the default.
require_head: yes# don't report if there is no head coverage reportand perhaps no point reporting on doc changes as they don't make any difference to the coverage and the 0% change comment just generates noise:
require_changes: true# only comment if there was a change in coverageThese options are documented here: https://docs.codecov.io/docs/codecovyml-reference#comment