Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify config filename in HfArgumentParser #6626

Merged
merged 1 commit into from
Aug 24, 2020

Conversation

jarednielsen
Copy link
Contributor

@jarednielsen jarednielsen commented Aug 20, 2020

Currently, HfArgumentParser will load arguments from a config file if that config file is the same name as the script being run. So train.py would have a corresponding train.args. This extends the method to load from any config file that is specified. So train.py could use a bert-large.args or a bert-small.args.

@codecov
Copy link

codecov bot commented Aug 20, 2020

Codecov Report

Merging #6626 into master will decrease coverage by 0.11%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6626      +/-   ##
==========================================
- Coverage   79.98%   79.87%   -0.12%     
==========================================
  Files         153      153              
  Lines       28005    28007       +2     
==========================================
- Hits        22401    22371      -30     
- Misses       5604     5636      +32     
Impacted Files Coverage Δ
src/transformers/hf_argparser.py 67.74% <0.00%> (-1.49%) ⬇️
src/transformers/modeling_tf_distilbert.py 64.47% <0.00%> (-32.95%) ⬇️
src/transformers/file_utils.py 82.44% <0.00%> (+0.25%) ⬆️
src/transformers/generation_tf_utils.py 80.70% <0.00%> (+1.50%) ⬆️
src/transformers/modeling_tf_flaubert.py 87.73% <0.00%> (+63.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc82047...cf515d1. Read the comment docs.

@julien-c
Copy link
Member

Looks like a nice addition, LGTM

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! cc @sgugger

@sgugger sgugger merged commit 1a779ad into huggingface:master Aug 24, 2020
@sgugger
Copy link
Collaborator

sgugger commented Aug 24, 2020

Thanks for adding this!

Zigur pushed a commit to Zigur/transformers that referenced this pull request Oct 26, 2020
fabiocapsouza pushed a commit to fabiocapsouza/transformers that referenced this pull request Nov 15, 2020
fabiocapsouza added a commit to fabiocapsouza/transformers that referenced this pull request Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants