Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] remove BartForConditionalGeneration.generate #6659

Merged
merged 1 commit into from
Aug 24, 2020

Conversation

stas00
Copy link
Contributor

@stas00 stas00 commented Aug 22, 2020

As suggested here: #6651 (comment)
this removes a generic generate doc with a large group of generate examples, none of which is relevant to BART. the BART class pre-amble doc already provides the examples.

Fixes #6651

As suggested here: huggingface#6651 (comment)
this removes generic `generate` doc with examples not-relevant to bart.
@codecov
Copy link

codecov bot commented Aug 22, 2020

Codecov Report

Merging #6659 into master will increase coverage by 0.61%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6659      +/-   ##
==========================================
+ Coverage   79.01%   79.62%   +0.61%     
==========================================
  Files         156      156              
  Lines       28248    28248              
==========================================
+ Hits        22320    22493     +173     
+ Misses       5928     5755     -173     
Impacted Files Coverage Δ
src/transformers/modeling_tf_flaubert.py 24.53% <0.00%> (-63.81%) ⬇️
src/transformers/generation_tf_utils.py 84.21% <0.00%> (-2.26%) ⬇️
src/transformers/modeling_tf_utils.py 86.64% <0.00%> (+1.30%) ⬆️
src/transformers/modeling_tf_electra.py 98.95% <0.00%> (+73.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f94151...2b5ac03. Read the comment docs.

Copy link
Contributor

@JetRunner JetRunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right!

@JetRunner JetRunner merged commit 912a21e into huggingface:master Aug 24, 2020
@stas00 stas00 deleted the patch-1 branch August 24, 2020 17:10
Zigur pushed a commit to Zigur/transformers that referenced this pull request Oct 26, 2020
As suggested here: huggingface#6651 (comment)
this removes generic `generate` doc with examples not-relevant to bart.
fabiocapsouza pushed a commit to fabiocapsouza/transformers that referenced this pull request Nov 15, 2020
As suggested here: huggingface#6651 (comment)
this removes generic `generate` doc with examples not-relevant to bart.
fabiocapsouza added a commit to fabiocapsouza/transformers that referenced this pull request Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[doc] bart doc examples aren't for bart
2 participants