Don't reset the dataset type + plug for rm unused columns #6683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6683 +/- ##
==========================================
- Coverage 79.65% 79.60% -0.05%
==========================================
Files 156 156
Lines 28250 28256 +6
==========================================
- Hits 22503 22494 -9
- Misses 5747 5762 +15
Continue to review full report at Codecov.
|
TevenLeScao
suggested changes
Aug 24, 2020
TevenLeScao
approved these changes
Aug 24, 2020
Zigur
pushed a commit
to Zigur/transformers
that referenced
this pull request
Oct 26, 2020
…e#6683) * Don't reset the type of the dataset * Formatting * Update trainer.py Co-authored-by: Teven <teven.lescao@gmail.com>
fabiocapsouza
pushed a commit
to fabiocapsouza/transformers
that referenced
this pull request
Nov 15, 2020
…e#6683) * Don't reset the type of the dataset * Formatting * Update trainer.py Co-authored-by: Teven <teven.lescao@gmail.com>
fabiocapsouza
added a commit
to fabiocapsouza/transformers
that referenced
this pull request
Nov 15, 2020
…ggingface#6683)" This reverts commit 9d4f322.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR avoids resetting the dataset type when removing columns, and also introduces a filed in
TrainingArgumentsto disable that behavior (in case the use wants to use some of those fields in an elaborate data collator).