PL: --adafactor option #6776
Merged
PL: --adafactor option #6776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sshleifer
commented
Aug 27, 2020
examples/lightning_base.py
Outdated
| @@ -137,7 +138,11 @@ def configure_optimizers(self): | |||
| "weight_decay": 0.0, | |||
| }, | |||
| ] | |||
| optimizer = AdamW(optimizer_grouped_parameters, lr=self.hparams.learning_rate, eps=self.hparams.adam_epsilon) | |||
| if self.hparams.adafactor: | |||
| optimizer = Adafactor(optimizer_grouped_parameters, lr=self.hparams.learning_rate, scale_parameter=False, relative_step=False) | |||
There was a problem hiding this comment.
I ignore the adam_epsilon clarg here, since the defaults are different. Could add a --adafactor_epsilon clarg, but I'll wait until somebody asks me to. So many clargs!
Codecov Report
@@ Coverage Diff @@
## master #6776 +/- ##
==========================================
- Coverage 78.47% 77.48% -1.00%
==========================================
Files 157 157
Lines 28569 28569
==========================================
- Hits 22420 22137 -283
- Misses 6149 6432 +283
Continue to review full report at Codecov.
|
Zigur
pushed a commit
to Zigur/transformers
that referenced
this pull request
Oct 26, 2020
fabiocapsouza
pushed a commit
to fabiocapsouza/transformers
that referenced
this pull request
Nov 15, 2020
fabiocapsouza
added a commit
to fabiocapsouza/transformers
that referenced
this pull request
Nov 15, 2020
This reverts commit 1179f87.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC @moscow25, @patil-suraj
I used the "External LR" setup and verified that is saves a significant amount of memory on pegasus finetuning.
Happy to add to Trainer.