Add quotes to paths in MeCab arguments #7142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without quotes directories with spaces in them will fail to be processed correctly.
JetRunner
approved these changes
Sep 15, 2020
mfuntowicz
pushed a commit
that referenced
this pull request
Sep 18, 2020
Without quotes directories with spaces in them will fail to be processed correctly.
Zigur
pushed a commit
to Zigur/transformers
that referenced
this pull request
Oct 26, 2020
Without quotes directories with spaces in them will fail to be processed correctly.
fabiocapsouza
pushed a commit
to fabiocapsouza/transformers
that referenced
this pull request
Nov 15, 2020
Without quotes directories with spaces in them will fail to be processed correctly.
fabiocapsouza
added a commit
to fabiocapsouza/transformers
that referenced
this pull request
Nov 15, 2020
This reverts commit 8d002a5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without quotes directories with spaces in them will fail to be processed
correctly.
This bug was first reported in the fugashi repo here. It's not a bug in fugashi - fugashi handles quoted paths correctly, and the relevant dictionary packages quote paths in
MECAB_ARGSto handle this case. Looks like it was missed when the dictionary handling code was added, since it doesn't useMECAB_ARGSbut instead builds args up from component parts.