Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix eval to compute rouge correctly for rouge_score #7356

Closed
wants to merge 3 commits into from
Closed

Fix eval to compute rouge correctly for rouge_score #7356

wants to merge 3 commits into from

Conversation

swethmandava
Copy link
Contributor

Fixes #6808

@swethmandava swethmandava mentioned this pull request Sep 24, 2020
Closed
@LysandreJik
Copy link
Member

Hi, for the code quality test to pass you should run make style (to apply the style changes) and check with make quality (to make sure there is none left) at the root of your transformers directory.

@codecov

This comment has been minimized.

Sign in to view
@sshleifer
Copy link
Contributor

sshleifer commented Sep 25, 2020 •
edited

Thanks for the contribution @swethmandava !

I'm going to run this over the weekend to see how metrics have changed.
Then if all goes well I'll merge this on Monday.
If you don't hear from me by Tuesday, please ping :)

@sshleifer sshleifer mentioned this pull request Sep 26, 2020
Merged
@sshleifer
Copy link
Contributor

I cleaned up and added tests in #7410

Metrics look good, let me know what you think of the new code! I will add you as PR coauthor!

@sshleifer sshleifer closed this Sep 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sshleifer sshleifer sshleifer left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bart-large-cnn ROUGE-L scores
3 participants
@swethmandava @LysandreJik @sshleifer