Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatter #7368

Merged
merged 2 commits into from Sep 24, 2020
Merged

Formatter #7368

merged 2 commits into from Sep 24, 2020

Conversation

LysandreJik
Copy link
Member

Add two new methods to the logging utility to automatically set the format like it is done in the examples/ folder.

@codecov
Copy link

codecov bot commented Sep 24, 2020

Codecov Report

Merging #7368 into master will decrease coverage by 1.34%.
The diff coverage is 22.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7368      +/-   ##
==========================================
- Coverage   76.51%   75.17%   -1.35%     
==========================================
  Files         181      181              
  Lines       34851    34860       +9     
==========================================
- Hits        26666    26205     -461     
- Misses       8185     8655     +470     
Impacted Files Coverage Δ
src/transformers/utils/logging.py 79.31% <22.22%> (-6.59%) ⬇️
src/transformers/tokenization_fsmt.py 20.34% <0.00%> (-74.90%) ⬇️
src/transformers/modeling_tf_electra.py 25.32% <0.00%> (-73.63%) ⬇️
src/transformers/modeling_layoutlm.py 25.06% <0.00%> (-69.40%) ⬇️
src/transformers/tokenization_phobert.py 21.80% <0.00%> (-61.66%) ⬇️
src/transformers/tokenization_bart.py 42.10% <0.00%> (-57.90%) ⬇️
src/transformers/tokenization_bert_generation.py 39.28% <0.00%> (-55.36%) ⬇️
src/transformers/trainer.py 13.34% <0.00%> (-42.28%) ⬇️
src/transformers/modeling_tf_gpt2.py 65.38% <0.00%> (-29.59%) ⬇️
src/transformers/training_args.py 62.69% <0.00%> (-28.58%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cffa42...ee18eb2. Read the comment docs.

Copy link
Contributor

@jplu jplu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM!

@LysandreJik LysandreJik merged commit 8d3bb78 into master Sep 24, 2020
@LysandreJik LysandreJik deleted the logging-formatter branch September 24, 2020 14:59
thevasudevgupta pushed a commit to thevasudevgupta/transformers that referenced this pull request Sep 29, 2020
fabiocapsouza pushed a commit to fabiocapsouza/transformers that referenced this pull request Nov 15, 2020
fabiocapsouza added a commit to fabiocapsouza/transformers that referenced this pull request Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants