Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TF generation] Fix typo #7582

Merged
merged 3 commits into from Oct 6, 2020
Merged

[TF generation] Fix typo #7582

merged 3 commits into from Oct 6, 2020

Conversation

SidJain1412
Copy link
Contributor

What does this PR do?

Typo + Parameter Assertion Fix

Before submitting

  • This PR fixes a typo or improves the docs (you can dimiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to the it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

@SidJain1412
Copy link
Contributor Author

I see that tests are failing, but shouldn't min_length and top_k simply not be allowed to go to zero?

@patrickvonplaten
Copy link
Contributor

patrickvonplaten commented Oct 6, 2020 •
edited

min_length defaults to 0 which is expteced behavior. top_k is 0 if it is not used => so I don't think we should do these changes.

@patrickvonplaten patrickvonplaten changed the title top_k and min_length assertion issue [TF generation] Fix typo Oct 6, 2020
@patrickvonplaten
Copy link
Contributor

We can fix the typo though ;-)

@SidJain1412
Copy link
Contributor Author

My bad, that makes sense 😄

@patrickvonplaten patrickvonplaten merged commit eda27f4 into huggingface:master Oct 6, 2020
fabiocapsouza pushed a commit to fabiocapsouza/transformers that referenced this pull request Nov 15, 2020
@SidJain1412 @patrickvonplaten @fabiocapsouza
[TF generation] Fix typo (huggingface#7582)
e826899 
* Fixing top_k and min_length assertions, and a typo fix

* Apply suggestions from code review

Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com>
fabiocapsouza added a commit to fabiocapsouza/transformers that referenced this pull request Nov 15, 2020
@fabiocapsouza
Revert "[TF generation] Fix typo (huggingface#7582)"
d0f6a47 
This reverts commit e826899.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickvonplaten patrickvonplaten patrickvonplaten left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SidJain1412 @patrickvonplaten