Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[s2s] configure lr_scheduler from command line #7641

Merged
merged 5 commits into from Oct 8, 2020

Conversation

patil-suraj
Copy link
Contributor

@patil-suraj patil-suraj commented Oct 7, 2020

What does this PR do?

This PR adds the ability to configure lr_scheduler from command line for Seq2SeqTrainer.

Fixes #7543

@sshleifer

examples/seq2seq/seq2seq_trainer.py Outdated Show resolved Hide resolved
examples/seq2seq/seq2seq_trainer.py Show resolved Hide resolved
examples/seq2seq/seq2seq_trainer.py Outdated Show resolved Hide resolved
Copy link
Contributor

@sshleifer sshleifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to merge with or without comment.

@sshleifer sshleifer merged commit 06a973f into huggingface:master Oct 8, 2020
@patil-suraj patil-suraj deleted the s2s-config-lrsched branch October 8, 2020 17:11
fabiocapsouza pushed a commit to fabiocapsouza/transformers that referenced this pull request Nov 15, 2020
fabiocapsouza added a commit to fabiocapsouza/transformers that referenced this pull request Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seq2SeqTrainer: missing features
2 participants