Improving Pipelines by defaulting to framework='tf' when pytorch seems unavailable. #7728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytorch seems unavailable.
|
Actually, This introduced a pretty big bug where nlp = pipeline(task) Would not work anymore. I tried a different solution around that. |
defaults Adding a new tests for each pipeline to check that pipeline(task) works too without manually adding the framework too.
Narsil
force-pushed
the
pipelines_tf_auto
branch
from
97cc165
to
d8100a7
Compare
LysandreJik
approved these changes
Oct 12, 2020
| @@ -823,3 +833,4 @@ def test_pt_defaults(self): | |||
| for task in self.pipelines: | |||
| with self.subTest(msg="Testing Torch defaults with PyTorch and {}".format(task)): | |||
| pipeline(task, framework="pt") | |||
| pipeline(task) | |||
There was a problem hiding this comment.
Thanks for completing the suite!
fabiocapsouza
pushed a commit
to fabiocapsouza/transformers
that referenced
this pull request
Nov 15, 2020
…s unavailable. (huggingface#7728) * Improving Pipelines by defaulting to framework='tf' when pytorch seems unavailable. * Actually changing the default resolution order to account for model defaults Adding a new tests for each pipeline to check that pipeline(task) works too without manually adding the framework too.
fabiocapsouza
added a commit
to fabiocapsouza/transformers
that referenced
this pull request
Nov 15, 2020
…rch seems unavailable. (huggingface#7728)" This reverts commit e7cf706.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When loading a model that was
tfonly and by passing only model by string without framework argument, it would fail with an odd error message:This PR corrects the
get_frameworkthat happens very early in the pipeline to detect the type of modelautomatically. It does trigger an early download, but that will happen anyway later.
Before submitting
Pull Request section?
to the it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors which may be interested in your PR.
@mfuntowicz