Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[testing] remove USE_CUDA #7861

Merged
merged 1 commit into from Oct 19, 2020
Merged

[testing] remove USE_CUDA #7861

merged 1 commit into from Oct 19, 2020

Conversation

stas00
Copy link
Contributor

@stas00 stas00 commented Oct 17, 2020

As discussed at #6349 this PR removes USE_CUDA.

I don't think I needed to add CUDA_VISIBLE_DEVICES="" to .circleci config files since those CIs have no gpus anyway.

@LysandreJik, @sgugger, @sshleifer

fixes: #6349

@stas00 stas00 changed the title remove USE_CUDA [testing] remove USE_CUDA Oct 17, 2020
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@LysandreJik LysandreJik merged commit 4eb61f8 into huggingface:master Oct 19, 2020
@stas00 stas00 deleted the use_cuda branch October 19, 2020 15:55
fabiocapsouza pushed a commit to fabiocapsouza/transformers that referenced this pull request Nov 15, 2020
fabiocapsouza added a commit to fabiocapsouza/transformers that referenced this pull request Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[testing] USE_CUDA default and intuitive skip decorators
4 participants