Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vectorize RepetitionPenaltyLogitsProcessor to improve performance #8598

Merged
merged 3 commits into from
Nov 20, 2020

Conversation

bdalal
Copy link
Contributor

@bdalal bdalal commented Nov 17, 2020

What does this PR do?

This PR replaces the nested loops in the RepetitionPenaltyLogitsProcessor with a vectorized implementation to provide speedups on long sequences of roughly 3 orders of magnitude on GPUs and 2 orders of magnitude on CPUs.

Fixes # 8596

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to the it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors which may be interested in your PR.

@patrickvonplaten

@bdalal
Copy link
Contributor Author

bdalal commented Nov 18, 2020

ValueError: Connection error, and we cannot find the requested files in the cached path. Please try again or make sure your Internet connection is on.

Seems like a flake. Tests passes locally.

Copy link
Contributor

@patrickvonplaten patrickvonplaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really great work @bdalal ! Tested in on equivalence even if input_ids contain same ids => and it's much faster, great!

Merging.

@patrickvonplaten patrickvonplaten merged commit 29bdb88 into huggingface:master Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants