Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2 typos in modeling_rag.py #8676

Merged
merged 2 commits into from
Dec 1, 2020
Merged

2 typos in modeling_rag.py #8676

merged 2 commits into from
Dec 1, 2020

Conversation

ratthachat
Copy link
Contributor

@ratthachat ratthachat commented Nov 20, 2020 •
edited

What does this PR do?

Fix 2 typos in modeling_rag.py
from_encoder_generator_configs --> from_question_encoder_generator_configs

Who can review?

@lhoestq

@ratthachat
2 typos - from_question_encoder_generator_configs
ce1d2d6 
fix 2 typos
from_encoder_generator_configs --> from_question_encoder_generator_configs
@ratthachat ratthachat changed the title 2 typos - from_question_encoder_generator_configs 2 typos in modeling_rag.py Nov 20, 2020
@LysandreJik
Copy link
Member

Hi! Could you run make style on your branch so that the code quality check passes? Thanks!

lhoestq
lhoestq reviewed Nov 25, 2020
View reviewed changes
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch ! Could you run make style to make the CI pass ?

@ratthachat
Copy link
Contributor Author

Hi guys, I only have mobile phone until Dec. 1. I will do it as soon as I can access PC.

@ratthachat
Copy link
Contributor Author

@lhoestq @LysandreJik done applying style. Sorry for late!

lhoestq
lhoestq approved these changes Dec 1, 2020
View reviewed changes
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks :)

@lhoestq lhoestq merged commit d366228 into huggingface:master Dec 1, 2020
stas00 pushed a commit to stas00/transformers that referenced this pull request Dec 5, 2020
@ratthachat @stas00
2 typos in modeling_rag.py (huggingface#8676)
434a7b7 
* 2 typos - from_question_encoder_generator_configs

fix 2 typos
from_encoder_generator_configs --> from_question_encoder_generator_configs

* apply make style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhoestq lhoestq lhoestq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ratthachat @LysandreJik @lhoestq