Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added instructions for syncing upstream master with forked master via PR #8745

Merged
merged 2 commits into from
Nov 24, 2020

Conversation

bdalal
Copy link
Contributor

@bdalal bdalal commented Nov 23, 2020

What does this PR do?

Fixes #8742

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the commit? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors which may be interested in your PR.

@stas00

@stas00
Copy link
Contributor

stas00 commented Nov 23, 2020

@LysandreJik, @sgugger

We are trying to give instructions to avoid:

  1. this:
    snapshot_3
    This is just one of the many examples - a snapshot is from the bottom of [s2s test_finetune_trainer] failing multigpu test #8400

    You can browse recent PRs for many more of these.

    These are not "legit" references - but automatic replays of PRs.

  2. unnecessary notifications for the developers mentioned in PR commit messages when these are replied in user forks.

CONTRIBUTING.md is not the most intuitive place for this, but at the moment there is no other place I could think of. At the very least if a new fork user starts doing this, we can refer them to this section.

Of course, the perfect solution would be for github to give repo admins an option to not allow ping-backs from repo forks. But I don't think it's available now.

@stas00 stas00 self-requested a review November 23, 2020 23:39
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding this!

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LysandreJik LysandreJik merged commit 8d4ed7e into huggingface:master Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add instructions for syncing forked masters to avoid references
4 participants