Extend typing to path-like objects in PretrainedConfig and PreTrainedModel
#8770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good idea! This could be done for tokenizers as well, no? (the |
added 6 commits
November 27, 2020 14:25
|
I have extended the same modifications to the tokenizers, as suggested by @thomwolf , and to auto classes too. |
stas00
pushed a commit
to stas00/transformers
that referenced
this pull request
Dec 5, 2020
…nedModel` (huggingface#8770) * update configuration_utils.py typing to allow pathlike objects when sensible * update modeling_utils.py typing to allow pathlike objects when sensible * black * update tokenization_utils_base.py typing to allow pathlike objects when sensible * update tokenization_utils_fast.py typing to allow pathlike objects when sensible * update configuration_auto.py typing to allow pathlike objects when sensible * update configuration_auto.py docstring to allow pathlike objects when sensible * update tokenization_auto.py docstring to allow pathlike objects when sensible * black
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In my experience, I often call the
from_pretrainedandsave_pretrainedmethods of models and configurations with a path-like variable rather than a string. Since the paths are then used by variousosfunctions, this works just fine: however, the relevant variables are typed as strings only, raising warnings when using an IDE 😧 .This PR extends the typing to
Union[str, os.PathLike]when relevant insidePretrainedConfigandPreTrainedModelmethods.Since passing a path-like object is already tacitly supported in most cases, no significant changes to the code are necessary. In a few places, the relevant variable needs to be turned to a string in order to support functions such as
is_remote_url.Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors which may be interested in your PR.
Maybe (documentation): @sgugger