Fix setup.py on Windows #8798
Merged
Fix setup.py on Windows #8798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stas00
reviewed
Nov 26, 2020
There was a problem hiding this comment.
It makes total sense that we want "\n" on windows. thank you, @jplu!
Not sure how examples/seq2seq/finetune.py sneaked in past autoformatters into master - can we move it into a separate PR as it has nothing to do with the proposed fix? And CI catches some errors on examples/seq2seq/finetune.py anyway - so something to fix there.
(edit: it was a bad PR merge #8478, reverted now - so if you rebase your branch this second file will go away)
jplu
force-pushed
the
fix-windows-setup
branch
from
893bb52
to
a2d4225
Compare
stas00
pushed a commit
to stas00/transformers
that referenced
this pull request
Dec 5, 2020
enforce unix newline encoding regardless of OS creating the file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the target
deps_table_updateon Windows by forcing the newline to be LF.