Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ctrl for sequence classification #8812

Merged
merged 7 commits into from
Dec 1, 2020
Merged

Ctrl for sequence classification #8812

merged 7 commits into from
Dec 1, 2020

Conversation

elk-cloner
Copy link
Contributor

What does this PR do?

Fixes #7623

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors which may be interested in your PR.

LysandreJik
LysandreJik approved these changes Nov 30, 2020
View reviewed changes
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@LysandreJik
Copy link
Member

Same as GPT-2, this would benefit from also handling padding on the left; I'll work on this in another PR.

sgugger
sgugger approved these changes Nov 30, 2020
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this new model!

patrickvonplaten
patrickvonplaten approved these changes Dec 1, 2020
View reviewed changes
Copy link
Contributor

@patrickvonplaten patrickvonplaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clean! Thanks for adding the model

@patrickvonplaten patrickvonplaten merged commit 4a9e502 into huggingface:master Dec 1, 2020
stas00 pushed a commit to stas00/transformers that referenced this pull request Dec 5, 2020
@elk-cloner @stas00
Ctrl for sequence classification (huggingface#8812)
342b29b 
* add CTRLForSequenceClassification

* pass local test

* merge with master

* fix modeling test for sequence classification

* fix deco

* fix assert
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickvonplaten patrickvonplaten patrickvonplaten approved these changes

@LysandreJik LysandreJik LysandreJik approved these changes

@sgugger sgugger sgugger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement PyTorch and/or TensorFlow sequence classification architectures for causal language models
4 participants
@elk-cloner @LysandreJik @patrickvonplaten @sgugger