Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Model parallel tests should return, not pass in non model parallel se… #8825

Merged
merged 1 commit into from
Nov 27, 2020
Merged

Model parallel tests should return, not pass in non model parallel se… #8825

merged 1 commit into from
Nov 27, 2020

Conversation

LysandreJik
Copy link
Member

…ttings.

pass does not skip the test; return does.

@LysandreJik LysandreJik merged commit 18c32ee into master Nov 27, 2020
@LysandreJik LysandreJik deleted the fix-model-parallel-tests branch November 27, 2020 21:41
stas00 pushed a commit to stas00/transformers that referenced this pull request Dec 5, 2020
@LysandreJik @stas00
Model parallel tests should return, not pass in non model parallel se…
e6f0013 
…ttings. (huggingface#8825)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@LysandreJik